Skip to content

Clean Code for mylyn.builds/org.eclipse.mylyn.jenkins.core #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Clean Code for mylyn.builds/org.eclipse.mylyn.jenkins.core #783

wants to merge 1 commit into from
+357 −363

Conversation

@eclipse-mylyn-bot
Copy link
Contributor

@eclipse-mylyn-bot eclipse-mylyn-bot commented Aug 9, 2025 •
edited
Loading

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

@github-actions
Copy link

github-actions bot commented Aug 9, 2025 •
edited
Loading

Test Results

 1 545 files  ±0   1 545 suites  ±0   1h 3m 42s ⏱️ + 1m 1s
 5 006 tests ±0   4 949 ✅ ±0   57 💤 ±0  0 ❌ ±0 
14 448 runs  ±0  14 277 ✅ ±0  171 💤 ±0  0 ❌ ±0 

Results for commit cde7beb. ± Comparison against base commit d2efceb.

♻️ This comment has been updated with latest results.

ruspl-afed
ruspl-afed reviewed Aug 9, 2025
View reviewed changes
...lyn.jenkins.core/src/org/eclipse/mylyn/internal/jenkins/core/client/JenkinsRunBuildForm.java

private static class NameValue {

@SuppressWarnings("unused")
Copy link
Contributor

@ruspl-afed ruspl-afed Aug 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps this is needed for persistence or something similar

Copy link
Contributor

@ruspl-afed ruspl-afed Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if we really need these fields @gnl42 ?

Copy link
Contributor

@BeckerFrank BeckerFrank Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is used to build a json string for the Jenkins Form; but I can not find a unit test where parm is filled. So not sure if we can safely delete parts and the private Classes.

@eclipse-mylyn-bot eclipse-mylyn-bot force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch 3 times, most recently from 5e4ee75 to c3159f8 Compare August 13, 2025 02:44
@ruspl-afed ruspl-afed force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch from c3159f8 to 5f914d7 Compare August 13, 2025 06:48
@eclipse-mylyn-bot eclipse-mylyn-bot force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch 8 times, most recently from e0b74e5 to 303ce63 Compare August 21, 2025 02:41
@eclipse-mylyn-bot eclipse-mylyn-bot force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch 5 times, most recently from c0aa40b to 8fcfc12 Compare August 28, 2025 02:39
@eclipse-mylyn-bot eclipse-mylyn-bot force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch from 8fcfc12 to fa58bc6 Compare September 4, 2025 02:36
@eclipse-mylyn-bot eclipse-mylyn-bot force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch 2 times, most recently from e4db08a to 617c532 Compare September 15, 2025 02:42
@eclipse-mylyn-bot eclipse-mylyn-bot force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch 5 times, most recently from 3135845 to 491f500 Compare September 27, 2025 02:35
@eclipse-mylyn-bot eclipse-mylyn-bot force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch from 491f500 to 4f8e33c Compare September 29, 2025 02:40
@eclipse-mylyn-bot eclipse-mylyn-bot force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch from 4f8e33c to c4275d9 Compare October 8, 2025 11:10
@ruspl-afed ruspl-afed force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch from c4275d9 to 51f1c78 Compare October 9, 2025 10:24
@eclipse-mylyn-bot eclipse-mylyn-bot force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch 2 times, most recently from 226e560 to dd77072 Compare October 11, 2025 02:36
@eclipse-mylyn-bot eclipse-mylyn-bot force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch 2 times, most recently from 5056d4a to 0bc2445 Compare October 31, 2025 02:43
@eclipse-mylyn-bot eclipse-mylyn-bot force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch 4 times, most recently from fca2482 to efe552e Compare November 21, 2025 07:53
@eclipse-mylyn-bot eclipse-mylyn-bot force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch 2 times, most recently from c100e72 to d498f1e Compare November 24, 2025 02:47
@eclipse-mylyn-bot eclipse-mylyn-bot force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch from d498f1e to cde7beb Compare November 27, 2025 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BeckerFrank BeckerFrank BeckerFrank left review comments

@ruspl-afed ruspl-afed ruspl-afed left review comments

Assignees

No one assigned

Labels

cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eclipse-mylyn-bot @BeckerFrank @ruspl-afed